This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Trim Rewrite Step #895
Merged
Trim Rewrite Step #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1e8e10a.
ScottCarda-MS
commented
Mar 29, 2021
cesarzc
reviewed
Mar 31, 2021
Contributor
Author
|
/azp build |
|
Command 'build' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
bettinaheim
reviewed
Apr 2, 2021
bettinaheim
reviewed
Apr 2, 2021
bettinaheim
reviewed
Apr 2, 2021
bettinaheim
approved these changes
Apr 2, 2021
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
I was hoping for one more test, but other than that looks good to me.
cesarzc
approved these changes
Apr 2, 2021
ScottCarda-MS
force-pushed
the
sccarda/TrimRewriteStep
branch
from
220618d to
00d868e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Syntax Tree Trimming rewrite step. Removes syntax tree trimming logic from the Monomorphization rewrite step. Monomorphization will now only remove all generics that are not intrinsic. The new rewrite step will remove all unused callables from the syntax tree except those callables needed by later rewrite steps.