This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Adding a command line option to force the execution of rewrite steps #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This should just be a matter of elevating the warning thrown by precondition failure to be treated as an error. That's a .NET thing right? I would be surprised if this issue needs changes to the code, but maybe @bettinaheim, you have already looked into that? |
Contributor
|
No, diagnostic severities are handled by the Q# compiler, not by .NET or MSBuild. |
…qsharp-compiler into beheim/commandLineArg
Contributor
Author
|
Incorporated into #915. |
This was referenced Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior is that if the precondition verification fails for rewrite steps, then the step is skipped and the compilation succeeds with a warning. While overall this seems reasonable behavior given that rewrite steps may come from a 3rd party, I also found this rather suboptimal for testing: When I set up the test for qir emission for a targeted executable, the test could technically succeed when/because the targeting step is skipped (since we test for a specific .ll it will fail regardless, but still seems risky since it is easy to overlook that the transformation in question is not executed when e.g. updating the test).
I hence went ahead and added a command line flag to force execution of rewrite steps and generate an error when the precondition is not met (see the doc comments for more detail).