This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add --dry-run option and implement --shots option #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarzc
reviewed
May 27, 2020
cesarzc
reviewed
May 27, 2020
cesarzc
suggested changes
May 27, 2020
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
It looks great! I only commented on one small feedback item to address.
cesarzc
approved these changes
May 27, 2020
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
Looks good! It is nice that the message displayed to the user when using the URI option has color.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to use
submit --dry-runsince:submit --validate, it looks like it is validating and submitting, rather than validating instead of submitting.validatecommand, but it would have all the same options as thesubmitcommand, so that seemed like unnecessarily duplication.I'll add the tests to #204.