This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Add tests for the standalone executable "submit" command #204
Merged
bamarsha
merged 13 commits into
feature/azure-quantum-preview
from
samarsha/azure-submit-tests
May 27, 2020
Merged
Add tests for the standalone executable "submit" command #204
bamarsha
merged 13 commits into
feature/azure-quantum-preview
from
samarsha/azure-submit-tests
May 27, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
approved these changes
May 20, 2020
Contributor
bettinaheim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
anpaz
approved these changes
May 20, 2020
cesarzc
reviewed
May 20, 2020
cesarzc
reviewed
May 20, 2020
cesarzc
approved these changes
May 20, 2020
2 tasks
Contributor
Author
|
After talking with @bettinaheim, I'm going to merge this PR as-is so we can merge the feature branch to master with some tests, but I'll add more tests to address the remaining comments in a separate PR. |
Contributor
|
@cesarzc @anpaz-msft. I've asked Sarah to make a separate PR to add the additional tests that you suggested and merge this one. I'd much rather have a good set of tests than no tests, and I want to make sure that we have sufficient time for the release testing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.