Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@bamarsha
Copy link
Contributor

@bamarsha bamarsha commented May 14, 2020

No description provided.

@bamarsha bamarsha requested review from anpaz, bettinaheim and cesarzc May 15, 2020 01:01
@bamarsha bamarsha changed the base branch from samarsha/azure-submit to feature/azure-quantum-preview May 16, 2020 01:09
@bamarsha bamarsha marked this pull request as ready for review May 16, 2020 01:09
Copy link
Contributor

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bamarsha
Copy link
Contributor Author

After talking with @bettinaheim, I'm going to merge this PR as-is so we can merge the feature branch to master with some tests, but I'll add more tests to address the remaining comments in a separate PR.

@bamarsha bamarsha merged commit 949003f into feature/azure-quantum-preview May 27, 2020
@bettinaheim
Copy link
Contributor

@cesarzc @anpaz-msft. I've asked Sarah to make a separate PR to add the additional tests that you suggested and merge this one. I'd much rather have a good set of tests than no tests, and I want to make sure that we have sufficient time for the release testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants