Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@bamarsha
Copy link
Contributor

@bamarsha bamarsha commented May 27, 2020

This is a follow-up to #204.

@bamarsha bamarsha requested review from anpaz, bettinaheim and cesarzc May 28, 2020 01:34
@bamarsha bamarsha marked this pull request as ready for review May 28, 2020 01:34
@bamarsha bamarsha changed the base branch from feature/azure-quantum-preview to master May 28, 2020 01:51
@bamarsha bamarsha marked this pull request as draft May 28, 2020 01:52
@bamarsha bamarsha force-pushed the samarsha/azure-submit-tests branch from 2668099 to 732ac64 Compare May 28, 2020 02:05
@bamarsha bamarsha force-pushed the samarsha/azure-submit-tests branch from 732ac64 to d638610 Compare May 28, 2020 02:18
@bamarsha bamarsha marked this pull request as ready for review May 28, 2020 02:18
Copy link
Contributor

@cesarzc cesarzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, the refactoring was very nice!

@bamarsha bamarsha merged commit 4fba91a into master Jun 4, 2020
@bamarsha bamarsha deleted the samarsha/azure-submit-tests branch June 4, 2020 23:36
AniketDalvi pushed a commit that referenced this pull request Jul 1, 2020
* Add test for --dry-run option

* Add tests for required submit options

* Add test for catching exceptions

* Add tests for shadowing submit options
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants