This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Update C# generation to use new position types #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace int * int with Position * Update compiler packages
# Conflicts: # src/Simulation/CsharpGeneration/Microsoft.Quantum.CsharpGeneration.fsproj # src/Simulation/QCTraceSimulator.Tests/Tests.Microsoft.Quantum.Simulation.QCTraceSimulatorRuntime.csproj # src/Simulation/QsharpCore/Microsoft.Quantum.QSharp.Core.csproj # src/Simulation/Simulators.Tests/TestProjects/HoneywellExe/HoneywellExe.csproj # src/Simulation/Simulators.Tests/TestProjects/IonQExe/IonQExe.csproj # src/Simulation/Simulators.Tests/TestProjects/Library with Spaces/Library with Spaces.csproj # src/Simulation/Simulators.Tests/TestProjects/Library1/Library1.csproj # src/Simulation/Simulators.Tests/TestProjects/Library2/Library2.csproj # src/Simulation/Simulators.Tests/TestProjects/QCIExe/QCIExe.csproj # src/Simulation/Simulators.Tests/TestProjects/QsharpExe/QsharpExe.csproj # src/Simulation/Simulators.Tests/TestProjects/UnitTests/UnitTests.csproj # src/Simulation/Simulators.Tests/Tests.Microsoft.Quantum.Simulators.csproj # src/Simulation/Simulators/Microsoft.Quantum.Simulators.csproj
Merge master into feature/position-cleanup
ScottCarda-MS
approved these changes
Aug 18, 2020
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
At some point we should really look into a better way to manage the referenced version of the QDK. Changing the version numbers was more of a change than the actual change in this PR.
added 2 commits
August 25, 2020 20:48
# Conflicts: # src/Simulation/CsharpGeneration/Microsoft.Quantum.CsharpGeneration.fsproj # src/Simulation/QCTraceSimulator.Tests/Tests.Microsoft.Quantum.Simulation.QCTraceSimulatorRuntime.csproj # src/Simulation/QsharpCore/Microsoft.Quantum.QSharp.Core.csproj # src/Simulation/Simulators.Tests/TestProjects/HoneywellExe/HoneywellExe.csproj # src/Simulation/Simulators.Tests/TestProjects/IonQExe/IonQExe.csproj # src/Simulation/Simulators.Tests/TestProjects/Library with Spaces/Library with Spaces.csproj # src/Simulation/Simulators.Tests/TestProjects/Library1/Library1.csproj # src/Simulation/Simulators.Tests/TestProjects/Library2/Library2.csproj # src/Simulation/Simulators.Tests/TestProjects/QCIExe/QCIExe.csproj # src/Simulation/Simulators.Tests/TestProjects/QsharpExe/QsharpExe.csproj # src/Simulation/Simulators.Tests/TestProjects/TargetedExe/TargetedExe.csproj # src/Simulation/Simulators.Tests/TestProjects/UnitTests/UnitTests.csproj # src/Simulation/Simulators.Tests/Tests.Microsoft.Quantum.Simulators.csproj # src/Simulation/Simulators/Microsoft.Quantum.Simulators.csproj
Merge master into feature/position-cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates C# generation to work with the changes to the position API made by microsoft/qsharp-compiler#531. It was previously reviewed in #313.