This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Merge master into feature/position-cleanup #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle operations as arguments in GetNonQubitArgumentsAsString * Handle null values for IApplyData types
* EncourageReuse option in QubitManager. Currently Qubit Manager tries to reuse released qubits as soon as possible and prefers it to allocating fresh unused ones. This is good for some scenarios, however, in other scenarios it may be preferrable to first allocate fresh unused qubits, and only then try to reuse released ones (oldest released first). Both behaviors are now possible via a backwards-compatible optional parameter in QubitManager constructor. * Review feedback * .
* Fix asserts in QubitManager * Remove asserts from QubitManager
* Protect simulator accessors via shared lock This fixes an intermittent crash by putting shared locks around the access of the `psis` vector, where create and destroy use an exclusive lock of the same mutex Fixes #335 * Fix factory_test.hpp * Make sure returned ptr is the same one
* Fixing circuit in test_gates to be deterministic `test_gates` in capi_test.cpp had a low but non-zero chance of measuring One instead of Zero, resulting in a test crash due to assertion failure. This rearranges the instructions to ensure the test correctly unprepares the state so that measurement is as deterministic as possible. Fixes #262 * use a more interesting circuit
* Replaced the nullable member access with regular member access for C# generated Slice.
# Conflicts: # src/Simulation/CsharpGeneration/Microsoft.Quantum.CsharpGeneration.fsproj # src/Simulation/QCTraceSimulator.Tests/Tests.Microsoft.Quantum.Simulation.QCTraceSimulatorRuntime.csproj # src/Simulation/QsharpCore/Microsoft.Quantum.QSharp.Core.csproj # src/Simulation/Simulators.Tests/TestProjects/HoneywellExe/HoneywellExe.csproj # src/Simulation/Simulators.Tests/TestProjects/IonQExe/IonQExe.csproj # src/Simulation/Simulators.Tests/TestProjects/Library with Spaces/Library with Spaces.csproj # src/Simulation/Simulators.Tests/TestProjects/Library1/Library1.csproj # src/Simulation/Simulators.Tests/TestProjects/Library2/Library2.csproj # src/Simulation/Simulators.Tests/TestProjects/QCIExe/QCIExe.csproj # src/Simulation/Simulators.Tests/TestProjects/QsharpExe/QsharpExe.csproj # src/Simulation/Simulators.Tests/TestProjects/UnitTests/UnitTests.csproj # src/Simulation/Simulators.Tests/Tests.Microsoft.Quantum.Simulators.csproj # src/Simulation/Simulators/Microsoft.Quantum.Simulators.csproj
ScottCarda-MS
approved these changes
Aug 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #342.