This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Return projects to original paths to fix e2e build #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionable information (#380) Improving the logging of WorkspaceClientException to include more informative data in its message from its inner exception. This is a follow up to #378 . - Instead of providing the full stack of the exception in the output, we extract more relevant fields from the source RestErrorException and provide them to the user. - Also, this change exposes header "x-ms-request-id"if present in the response, for additional debugging.
8 tasks
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ScottCarda-MS
approved these changes
Oct 14, 2020
Contributor
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Collaborator
Author
|
There are some failures in iqsharp python tests that I think will require some work to fix. I'd like to get this PR merged up to the feature branch and tackle those in a separate one to make that work easier to review in isolation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e build failures were due to the project path changes introduced by the feature work. This reverts the Simulation\Simulators.Core folder to Simulation\Simulators to fix e2e build.
This change is mostly file renames and path fixes, and the only change to functionality was a bug fix in
MResetYto add the adjoint functor when callingS.