This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Added DrawRandomInt() and Message() #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
requested review from
IrinaYatsenko,
bettinaheim,
cgranade and
guenp
kuzminrobin
changed the title
cgranade
reviewed
Feb 10, 2021
kuzminrobin
force-pushed
the
kuzminrobin/mathfuncs
branch
from
8c8454e to
a0e023b
Compare
cgranade
reviewed
Feb 16, 2021
cesarzc
reviewed
Feb 16, 2021
cesarzc
reviewed
Feb 16, 2021
IrinaYatsenko
approved these changes
Feb 16, 2021
Contributor
IrinaYatsenko
left a comment
IrinaYatsenko
left a comment
There was a problem hiding this comment.
Could you please run clang format on the files you touched? As far as the substance of the change is concerned, my only big concern is the tests for random (see my in-file comment), which I'm leaving to your discretion.
cesarzc
reviewed
Feb 17, 2021
cesarzc
approved these changes
Feb 17, 2021
kuzminrobin
force-pushed
the
kuzminrobin/mathfuncs
branch
from
6bd6a0b to
7f6fd2f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step for #501