Generate QIR during pipeline #522
Conversation
swernli
requested review from
IrinaYatsenko,
bamarsha,
bettinaheim,
cgranade and
guenp
|
@irinayat-MS Good suggestions! Adding the .ll to the artifacts and building such that it matches the configuration in the environment should be easy updates. |
| Write-Host "##vso[task.logissue type=error;]Failed to compile Q# project at '$qirStaticPath' into QIR." | ||
| return | ||
| } | ||
| Copy-Item -Path (Join-Path $qirStaticPath qir *.ll) -Destination (Split-Path $qirStaticPath -Parent) |
There was a problem hiding this comment.
Should we perhaps delete the currently generated QIR files that are in the /src/QirRuntime/test/QIR-static folder to avoid confusion?
There was a problem hiding this comment.
Yes, it would be good to delete the one file that is now being generated (the second file was manually authored and covers functionality not supported by Q# but present in QIR spec)
There was a problem hiding this comment.
This change does remove that file.
IrinaYatsenko
left a comment
IrinaYatsenko
left a comment
There was a problem hiding this comment.
Awesome! Thanks for doing this!
|
|
||
| if ($Env:ENABLE_QIRRUNTIME -eq "true") { | ||
| Write-Host "##[info]Compile Q# Projects into QIR" | ||
| $qirStaticPath = Join-Path $PSScriptRoot test QIR-static qsharp |
There was a problem hiding this comment.
Beyond the scope of this PR, but we may want to consider in the future making this rely on PowerShell cmdlet functions that wrap dotnet build and ensure that arguments such as build configuration and assembly versions are set from environment variables in a uniform way.
This updates the QirRuntime pipeline to expect the qir-static.ll file to be generated at runtime instead of checked in, now that we can support cross-platform QIR generation properly.
This also updates the pipeline to use pwsh instead of powershell to get uniform behavior on Windows.