Cleanup qdk.dll build #524
Conversation
| @@ -1,1690 +1,1691 @@ | |||
| %Result = type opaque | |||
There was a problem hiding this comment.
I thought this file was deleted by my change in #522 which should have updated the gitignore too. How is it ending up in the diff here?
There was a problem hiding this comment.
Good question. Don't know. I deleted the file and rebuilt locally again, and it was correctly filtered out by .gitignore this time... Thanks for catching this!
Oh, I see! @kuzminrobin change ec763fb added the file back. Likely, because it was updated compared to the pre-delete state and merge decided to resurrect it... I guess, we'll need to keep an eye on this for a while.
There was a problem hiding this comment.
Looks like during rebasing my branch, I resolved the conflict incorrectly such that the file was recovered.
I assume that now this file needs to be always generated (if we build the tests in a clean directory).
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
Clean up looks good, just one question about why the .ll file seems to have reappeared.
|
Approving. |
Fixes #519
Also moved a couple headers from lib/QIR into public and took the opportunity to replace <assert.h> and <string.h> includes with and respectively.