This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Multiple Entry Points For Entry Point Driver #528
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and is set as default.
bamarsha
suggested changes
Feb 25, 2021
bamarsha
reviewed
Mar 8, 2021
ScottCarda-MS
commented
Mar 18, 2021
bettinaheim
reviewed
Mar 18, 2021
ScottCarda-MS
commented
Mar 22, 2021
bettinaheim
approved these changes
Mar 23, 2021
Contributor
bettinaheim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the Entry Point Driver and C# generation to accommodate Q# code having multiple entry points.
Major Changes:
Mainmethod.Mainmethod is generated in its own namespace and class:__QsEntryPoint__.__QsEntryPoint__.generateMainSourceto the C# gen'sEntryPointmodule. This function parallelsgenerateSourcein the same module and generates the content for the C# gen's Main file..g.csfor the C# of the Q# operations (same as before).g.EntryPoint.csinstead ofEntryPoint.g.csfor generated entry point classesEntryPoint.g.Main.csfor the name of the new file containing theMainmethod.Microsoft.Quantum.EntryPointDriver.Azure.Submitwas made public as it is used in the generated C# for entry points.Microsoft.Quantum.EntryPointDriver.Simulation.Simulatewas made public as it is used in the generated C# for entry points.IEntryPointinterface was changed considerably.Dependent PR on compiler repo: microsoft/qsharp-compiler#881