This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Allow Multiple Entry Points #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
requested review from
bamarsha,
bettinaheim,
cesarzc and
swernli
bamarsha
suggested changes
Feb 25, 2021
bamarsha
previously requested changes
Mar 18, 2021
bettinaheim
reviewed
Mar 18, 2021
bettinaheim
reviewed
Mar 23, 2021
bettinaheim
approved these changes
Mar 23, 2021
bettinaheim
dismissed
bamarsha’s stale review
Requested changes have been addressed.
…osoft/qsharp-compiler into sccarda/MultipleEntryPoints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the logic that throws an error when multiple entry points are present in a compilation.
Major Changes:
Added a public-facingWriteFilemethod toCompilationLoaderthat allows files to be written even when they are not related to a source file. This is used by the runtime PR to write the new generated C# Entry Point file.This is should be merged in tandem with this PR on the runtime PR: microsoft/qsharp-runtime#528