This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Turn on QirRuntime build/validation by default #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
requested review from
bamarsha,
bettinaheim,
cesarzc,
cgranade,
kuzminrobin and
ricardo-espinoza
swernli
force-pushed
the
swernli/enable-qir
branch
from
edabff6 to
e79dd52
Compare
ricardo-espinoza
approved these changes
Mar 16, 2021
cesarzc
approved these changes
Mar 16, 2021
swernli
force-pushed
the
swernli/enable-qir
branch
from
e8f7a54 to
deda0ac
Compare
cgranade
reviewed
Mar 16, 2021
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp3.1</TargetFramework> | ||
| <QirGeneration>True</QirGeneration> |
Contributor
There was a problem hiding this comment.
Minor, but is the capitalization difference here significant?
Collaborator
Author
There was a problem hiding this comment.
it isn't, and I think it snuck into one of projects and then got copy pasted around.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that QIR support has merged to main across the repos, we are ready to have build and validation on by default. This will also ensure e2e build produce QIR Runtime libraries as artifacts for continued development without having to rely on PR builds to produce them.