Skip to content

Conversation

@TatianaKapos
Copy link
Contributor

@TatianaKapos TatianaKapos commented Jul 6, 2022

Description

Narrator now calls out the state (expanded or collapse) of navigation bar, the group of controls on home page, and correctly calls out button request/state on Permissions Example Page.

Why

Resolves #227
Resolves #228
Resolves #224
Resolves #226
Resolves #229

@TatianaKapos TatianaKapos marked this pull request as ready for review July 8, 2022 21:31
Copy link
Contributor

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agniuks
Copy link
Contributor

agniuks commented Jul 11, 2022

For the nav pane issues, maybe we can also upstream some of this work into react-navigation drawer?

@TatianaKapos
Copy link
Contributor Author

@AgneLukoseviciute yeah that's a good idea! Which issue were you looking at specifically? Most of these were resolved with just adding an accesssibilityLabel so not sure the expected output when using react-navigation drawer

@TatianaKapos TatianaKapos merged commit 4fefb60 into microsoft:main Jul 11, 2022
@agniuks
Copy link
Contributor

agniuks commented Jul 11, 2022

@AgneLukoseviciute yeah that's a good idea! Which issue were you looking at specifically? Most of these were resolved with just adding an accesssibilityLabel so not sure the expected output when using react-navigation drawer

I think we should be able to add the accessibilityState expanded prop (which fixed #227) to their DrawerToggleButton so the added accessibility is provided for "free" and apps don't have to do extra work.

And then for the one where you added accessibilityLabels (#226), ideally react-navigation would just use the text of the button as the default accessibilityLabel so we don't need to set it explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment