cherry-pick VoiceOver accessibility issues from master to 0.62-stable #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoiceOver accessibility issues in RN .62 (microsoft#603) * Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae0. * Remove unnecessary android builds and tar file upload. * RN .62 accessiblity fixes. * Fix regression in recursive accessiblityLabel text. * Changed per PR feedback. * Add "disclosure" role for mac mapping to NSAccessibilityDisclosureTriangleRole. Make accessibilityValue return "checked" state for checkbox, radiobutton, and disclosure roles. * CocoaPods does not like podspec version numbers that are 0.0.0. The canary builds set the version to 0.0.0-<commithash> via `node scripts/bump-oss-version.js --nigh tly` which causes the "Verify react-native-macos-init MacDebug" CI test to fail bec ause `pod install` fails due to `.podspec` versions that are 0.0.0. Add a `--testi ng` switch to `bump-oss-version.js` that changes the version to 1000.0.0 and use th at switch in `react-native-macos-init.yml`. Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com>
|
alloy
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The previous PR to master #603 made several fixes for VoiceOver accessibility. This change cherry-picks those fixes (commit aac33da) into the 0.62-stable branch.
Changelog
[macOS] [fixed] - cherry-pick VoiceOver accessibility issues from master to 0.62-stable
Test Plan
The original PR #603 contains comprehensive test notes.
Microsoft Reviewers: Open in CodeFlow