Skip to content

Fix selection highlight regression in RNTester list #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alloy merged 1 commit into from
Dec 2, 2020
Merged

Fix selection highlight regression in RNTester list #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions RNTester/js/components/RNTesterExampleList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ class RowComponent extends React.PureComponent<{
onPress={this._onPress}>
<View
style={[
rowStyle, // TODO(macOS ISS#2323203)
{backgroundColor: theme.SystemBackgroundColor},
Copy link
Member

@alloy alloy Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are the right colours brought in by theme.SystemBackgroundColor?

Copy link
Author

@thymikee thymikee Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list has properly being changed when switching dark mode on/off so I guess so? Because it worked as expected to me, I didn't really investigated what's under theme.SystemBackgroundColor really

Copy link
Member

@alloy alloy Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough 👍

rowStyle, // TODO(macOS ISS#2323203)
]}>
<Text style={[styles.rowTitleText, {color: theme.LabelColor}]}>
{item.module.title}
Expand Down Expand Up @@ -290,19 +290,6 @@ const styles = StyleSheet.create({
fontSize: 11,
},
row: {
...Platform.select({
// [TODO(macOS ISS#2323203)
macos: {
backgroundColor: PlatformColor('controlBackgroundColor'),
},
ios: {
backgroundColor: PlatformColor('secondarySystemGroupedBackgroundColor'),
},
default: {
// ]TODO(macOS ISS#2323203)
backgroundColor: 'white',
}, // [TODO(macOS ISS#2323203)
}), // ]TODO(macOS ISS#2323203)
justifyContent: 'center',
paddingHorizontal: 15,
paddingVertical: 8,
Expand Down