Fix selection highlight regression in RNTester list #660
Conversation
ghost
added
alloy
left a comment
alloy
left a comment
There was a problem hiding this comment.
Nice 👌
As for dark theme, that's a larger work item that applies to all of RNTester and should probably start upstream. If you’re up for that do please have a go at it 🙏
| <View | ||
| style={[ | ||
| rowStyle, // TODO(macOS ISS#2323203) | ||
| {backgroundColor: theme.SystemBackgroundColor}, |
There was a problem hiding this comment.
So are the right colours brought in by theme.SystemBackgroundColor?
There was a problem hiding this comment.
The list has properly being changed when switching dark mode on/off so I guess so? Because it worked as expected to me, I didn't really investigated what's under theme.SystemBackgroundColor really
|
I’m re-running the failed CI task. |
|
@chrisglein Ooh, I see the bot propagates labels from the issue that a PR fixes; nifty! However, seeing as this only applies to RNTester I don’t think there’s a real need to backport this, or do you think differently? EDIT: I realise that the determination that this only applies to RNTester came after filing the issue. Had it been a different underlying cause then it would have totally made sense to backport, but seeing as that’s not the case I think we’re in alignment in this not needing backporting work at this time. |
|
Thanks for reviewing this so quickly! Nice contributing experience 😊 |
2 participants
Please select one of the following
Summary
Wanted to tackle #605 which was described as a regression likely when merging upstream virtualized lists changes. However, as I tested this through it turned out that it's the styling override that's to blame, not the actual functionality, which seem to work as intended.
Fixes #605
Changelog
[macOS] [Fixed] - Fix selection highlight regression in RNTester list
Test Plan
This color doesn't look great in dark mode tho. But I didn't want to diverge too much from the original RNTester. Suggestions welcome.
Microsoft Reviewers: Open in CodeFlow