forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 162
macOS keyboard accessibility API alignment & support #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8df39e1
Update RCTCxxBridge.mm
HeyImChris 4a9bcbd
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris e8d2d8b
Merge pull request #1 from microsoft/master
HeyImChris ab71c3b
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris e40c784
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 204ddb3
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris a76bcc1
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 7d85560
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 7011dc4
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris abfbabf
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris 19aa189
Merge branch 'master' of https://github.com/microsoft/react-native-macos
HeyImChris c3866a0
escape, enter support, align more tightly with win
HeyImChris 9060f47
Update tests
HeyImChris 3ce4fb1
Merge branch 'master' into keyboardingFixes
HeyImChris d315305
improve arrow js compatibility
HeyImChris 10c93e1
Merge branch 'keyboardingFixes' of https://github.com/HeyImChris/reac…
HeyImChris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also include combination keydown input? like enter should be differently recognized from enter+ctrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, but I don't mind if we leave that for later
In reply to: 570401738 [](ancestors = 570401738)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't quite have that but we do pass all modifier keys back to clients along with the key press so clients can still filter by ctrl+enter vs. enter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, late to the PRty 😉 - in RNW this is represented with the
keyUpEventsprop, which is an array of objects that do specify modifier keys as well. Also, it uses down "Escape", which is correct according to the standard. The Keyboard API doc actually incorrectly uses "Esc", but RNW is doing the right thing. cc @harinikmsft