macOS keyboard accessibility API alignment & support #707
Conversation
Merge upstream into fork
| acceptsKeyboardFocus={true} | ||
| enableFocusRing={true} | ||
| validKeysDown={['a', 'b', 'x', 'rightArrow']} | ||
| validKeysDown={['g', 'Esc', 'Enter', 'ArrowLeft']} |
There was a problem hiding this comment.
can we also include combination keydown input? like enter should be differently recognized from enter+ctrl
There was a problem hiding this comment.
There was a problem hiding this comment.
We don't quite have that but we do pass all modifier keys back to clients along with the key press so clients can still filter by ctrl+enter vs. enter
There was a problem hiding this comment.
Sorry, late to the PRty 😉 - in RNW this is represented with the keyUpEvents prop, which is an array of objects that do specify modifier keys as well. Also, it uses down "Escape", which is correct according to the standard. The Keyboard API doc actually incorrectly uses "Esc", but RNW is doing the right thing. cc @harinikmsft
* Update RCTCxxBridge.mm * escape, enter support, align more tightly with win * Update tests * improve arrow js compatibility
* Update RCTCxxBridge.mm * escape, enter support, align more tightly with win * Update tests * improve arrow js compatibility
| acceptsKeyboardFocus={true} | ||
| enableFocusRing={true} | ||
| validKeysDown={['a', 'b', 'x', 'rightArrow']} | ||
| validKeysDown={['g', 'Esc', 'Enter', 'ArrowLeft']} |
There was a problem hiding this comment.
Sorry, late to the PRty 😉 - in RNW this is represented with the keyUpEvents prop, which is an array of objects that do specify modifier keys as well. Also, it uses down "Escape", which is correct according to the standard. The Keyboard API doc actually incorrectly uses "Esc", but RNW is doing the right thing. cc @harinikmsft
| @"ArrowLeft" : @(leftArrowKey), | ||
| @"ArrowRight" : @(rightArrowKey), | ||
| @"ArrowUp" : @(upArrowKey), | ||
| @"ArrowDown" : @(downArrowKey), |
There was a problem hiding this comment.
These probably shouldn't be here anymore as the key property now correctly represents them.
4 participants
Please select one of the following
Summary
Addresses this issue
Align more closely with the Windows API set and add
EscapeandEntersupport.Win spec
Generic Msft event handler ref
TODO: Once this merges it needs to be cherry picked into the 0.62-stable and 0.63-stable branches.
Changelog
[macOS] [Bug] - enter, escape keyboarding support
Test Plan
Tested valid keys in RNTester
Microsoft Reviewers: Open in CodeFlow