Add nullability checks #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream into fork
harrieshin
approved these changes
Feb 2, 2021
HeyImChris
added a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Feb 4, 2021
* Update RCTCxxBridge.mm * add nullability checks
4 tasks
HeyImChris
added a commit
that referenced
this pull request
Feb 4, 2021
HeyImChris
added a commit
that referenced
this pull request
Feb 9, 2021
HeyImChris
added a commit
that referenced
this pull request
Feb 10, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * cherry pick RCTLinkingManagerCls to 63
HeyImChris
added a commit
that referenced
this pull request
Feb 17, 2021
HeyImChris
added a commit
that referenced
this pull request
Feb 18, 2021
HeyImChris
added a commit
that referenced
this pull request
Feb 23, 2021
HeyImChris
added a commit
that referenced
this pull request
Feb 26, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * CI should run on PRs to future stable branches (#718) * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces (#678) * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces * [ado] Remove no longer needed homebrew fix Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> * update podfile.lock * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces (#678) * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces * [ado] Remove no longer needed homebrew fix Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> * update podfile.lock * windows dep updates to 63 Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: Sergi Mansilla <sergi@sergimansilla.com> Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
HeyImChris
added a commit
that referenced
this pull request
Mar 3, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * Minor tweaks to RCTDevSettings (#696) * Export RCTDevSettings noop impl on shipping builds to JS * Add a protocol method to get all set keys on dev settings * tag changes * podfile fix Co-authored-by: Navneet Kambo <72474613+nakambo@users.noreply.github.com>
HeyImChris
added a commit
that referenced
this pull request
Mar 3, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * Fix ability to call focus()/blur() on any view (#738) This fixes a regression from when we upgraded to 0.63 where we could no longer call `focus()` or `blur()` on any `View` (including `Text`). This regression was due to a change that dispatches these as commands (to be compatible with Fabric) instead of directly using `UIManager` to change focus. Only the `TextInput` supported these commands. * pod install * Fix ability to call focus()/blur() on any view (#738) This fixes a regression from when we upgraded to 0.63 where we could no longer call `focus()` or `blur()` on any `View` (including `Text`). This regression was due to a change that dispatches these as commands (to be compatible with Fabric) instead of directly using `UIManager` to change focus. Only the `TextInput` supported these commands. Co-authored-by: Scott Kyle <scott@appden.com>
HeyImChris
added a commit
that referenced
this pull request
Apr 16, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * fix up failing podfile
HeyImChris
added a commit
that referenced
this pull request
Apr 20, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * fix up 0.63 macOS app delegate
HeyImChris
added a commit
that referenced
this pull request
Apr 26, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * add platform check * pod install repo update
HeyImChris
added a commit
that referenced
this pull request
May 14, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * Nil check our run loop thread (#771) * Update RCTCxxBridge.mm * Update RCTCxxBridge.mm * run loop nil check Co-authored-by: Chris Hogan <chrishogan@Chriss-MacBook-Pro-2.local> * podfile lock Co-authored-by: Chris Hogan <chrishogan@Chriss-MacBook-Pro-2.local>
HeyImChris
added a commit
that referenced
this pull request
Jun 1, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * Check a nil URL to fix crashes connecting to socket (#785) * Update RCTCxxBridge.mm * Update RCTCxxBridge.mm * nil check websocket URL * use RCTAssertParam Co-authored-by: Chris Hogan <chrishogan@Chriss-MacBook-Pro-2.local> * pod install Co-authored-by: Chris Hogan <chrishogan@Chriss-MacBook-Pro-2.local>
HeyImChris
added a commit
that referenced
this pull request
Jun 1, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * Revert "Split loadApplicationScript into initializeRuntime and loadBundle (facebook#27844)" This reverts commit 6f627f6. * pod fixes * Revert "Split loadApplicationScript into initializeRuntime and loadBundle (facebook#27844)" This reverts commit 6f627f6. * pod fixes * pod update * pod install * fix libevents and flipper dependencies * flipper updates * disable sonar kit * Revert "Split loadApplicationScript into initializeRuntime and loadBundle (facebook#27844)" This reverts commit 6f627f6. * pod fixes * flipper updates * disable sonar kit * pod install
HeyImChris
added a commit
that referenced
this pull request
Jun 29, 2021
* Add nullability checks (#704) * Update RCTCxxBridge.mm * add nullability checks * remove extraneous devsettings check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This fix is necessary for devmain builds to succeed with 0.63. Some downstream deps have stricter warnings enabled around nullability. We should be explicit here to keep the compilers happy and also give more clarity to what we expect in code regarding the nullability.
Changelog
[iOS/macOS] [Fixed] - Fix nullability check warnings
Test Plan
Tested this downstream in devmain and with these fixes, our projects can build with the nullability warnings on.
Microsoft Reviewers: Open in CodeFlow