-
Notifications
You must be signed in to change notification settings - Fork 162
Undo a rearchitecture that breaks us downstream #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Update RCTCxxBridge.mm * add nullability checks
…ndle (facebook#27844)" This reverts commit 6f627f6.
|
This reverts commit 73224cf.
This reverts commit 73224cf, which itself was a revert of a commit. So we're bringing back the original change. We thought it would break things downstream for us, but are electing to instead fix things downstream rather than undo this commit.
Please select one of the following
Summary
This change I'm reverting for the 63 stable branch is an improvement in that we only do the global JS variable init once, but it has the downside that it splits out the JS runtime init from the bundle loading which breaks a scenario we rely on downstream.
I'm still investigating how to rearchitect our downstream client code to be compatible with this change which is why I'm just making this revert in 0.63 instead of master. In the short term, we need to unblock ourselves and anyone else that isn't set up to properly handle this new scenario of rearchitecting the SDX setup.
I also hit some failures using Flipper. We need a different version than is compatible so for now I disabled Flipper as we don't need it on.
git revert 6f627f684bb6506a677c9632b2710e4a541690a9Changelog
[General] [Minor] - git revert a 63 initialization rearchitecture
Test Plan
This is going back to what is in 0.62 so it should all still work as well as 0.62 did. I ran the test app and basic scenarios seem to still work as expected.