Skip to content

Conversation

@Saadnajmi
Copy link
Collaborator

This reverts commit 73224cf, which itself was a revert of a commit. So we're bringing back the original change.

We thought it would break things downstream for us, but are electing to instead fix things downstream rather than undo this commit.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@Saadnajmi Saadnajmi requested a review from alloy as a code owner June 11, 2021 18:14
@pull-bot
Copy link

pull-bot commented Jun 11, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 22516c0

@harrieshin harrieshin merged commit 4fd4657 into microsoft:0.63-stable Jun 12, 2021
@Saadnajmi Saadnajmi deleted the undo-undo-rearchitecture branch August 22, 2021 12:54
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Sep 21, 2022
Summary:
X-link: facebook/hermes#793

Add a JSI API for constructing `ArrayBuffer`s from a user provided
`jsi::MutableBuffer`.

Changelog: [General][Added] Added ability to construct ArrayBuffers from existing memory buffers.

Reviewed By: jpporto

Differential Revision: D37744467

fbshipit-source-id: 9d9ece00d1dbde341846c45fa30c935b5fa81e9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants