Fix 0.63-stable CI, remove #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update RCTCxxBridge.mm * add nullability checks
…lit it if it contains spaces (microsoft#678) * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces * [ado] Remove no longer needed homebrew fix Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
anandrajeswaran
approved these changes
Feb 24, 2021
…lit it if it contains spaces (microsoft#678) * Enclose the app path in quotes, so that the `open` command doesn't split it if it contains spaces * [ado] Remove no longer needed homebrew fix Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Fix broken CI- bring in fix from master
git cherry-pick b192f9c
Test Plan
If CI succeeds then this is correct as it's just a CI change
Microsoft Reviewers: Open in CodeFlow