-
Notifications
You must be signed in to change notification settings - Fork 162
Fix deadlock #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deadlock #798
Conversation
* Update RCTCxxBridge.mm * add nullability checks
|
Please select one of the following
Summary
This extra check was added over two years ago before this was migrated to GitHub. In that migration we lost the source history but it's fairly easy to piece together why this was added and therefore, why we can remove it.
This check I'm removing was added in a bulk add next to the
RCT_DEVmacros throughout the code base. It's causing problems being here because calling into DevSettings before we finish initialization is deadlocking in that it tries to create the DevSettings module if it doesn't exist. This gets into a race condition where it tries to create a module before RN is in a state that modules can be created.Removing it is safe because the check it's around is completely innocuous and won't matter if it wraps the executor in debug or ship builds either way.
This change allows us to enable web debugging scenarios downstream by fixing a crucial deadlock issue.
Changelog
[Apple] [Bug] - Fix devsettings deadlock
Test Plan
Tested downstream and web debugging works