Skip to content

Conversation

@appden
Copy link

@appden appden commented Feb 10, 2021

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This aligns the name to be same as in react-native-windows and the standard.

Changelog

[macOS] [Fixed] - Change key identifier from "Esc" -> "Escape"

Test Plan

Confirmed correct key identifier is logged in the Key Event example in RNTester.

Microsoft Reviewers: Open in CodeFlow

@harrieshin
Copy link

lets make sure we cherry pick to .63 stable as well!

@HeyImChris HeyImChris merged commit df4e7da into microsoft:master Feb 11, 2021
@HeyImChris
Copy link

lets make sure we cherry pick to .63 stable as well!

@appden are you able to make this change in the 0.63-stable branch as well? If not I can, just let me know

@appden
Copy link
Author

appden commented Feb 11, 2021

@appden are you able to make this change in the 0.63-stable branch as well? If not I can, just let me know

Just clarifying: are you asking that I open another PR targeting that branch?

HeyImChris pushed a commit to HeyImChris/react-native-macos that referenced this pull request Feb 11, 2021
@HeyImChris
Copy link

@appden are you able to make this change in the 0.63-stable branch as well? If not I can, just let me know

Just clarifying: are you asking that I open another PR targeting that branch?

Hey not a problem, here's what I meant 0.63-stable PR

HeyImChris added a commit that referenced this pull request Feb 17, 2021
* Add nullability checks (#704)

* Update RCTCxxBridge.mm

* add nullability checks

* Change key identifier from "Esc" -> "Escape" (#720)

Co-authored-by: Scott Kyle <scott@appden.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants