Skip to content

Change key identifier from "Esc" -> "Escape" #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeyImChris merged 1 commit into from
Feb 11, 2021
Merged

Change key identifier from "Esc" -> "Escape" #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RNTester/js/examples/KeyboardEventsExample/KeyboardEventsExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class KeyEventExample extends React.Component<{}, State> {
<View
acceptsKeyboardFocus={true}
enableFocusRing={true}
validKeysDown={['g', 'Esc', 'Enter', 'ArrowLeft']}
validKeysDown={['g', 'Escape', 'Enter', 'ArrowLeft']}
onKeyDown={this.onKeyDownEvent}
validKeysUp={['c', 'd']}
onKeyUp={this.onKeyUpEvent}>
Expand Down
2 changes: 1 addition & 1 deletion React/Views/RCTView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,7 +1716,7 @@ - (NSString*)keyIsValid:(NSString*)key left:(BOOL)leftArrowPressed right:(BOOL)r
BOOL downArrowValidityCheck = [validKeys containsObject:downArrowPressKey] && downArrowPressed;

if (escapeKeyValidityCheck) {
keyToReturn = @"Esc";
keyToReturn = @"Escape";
} else if (enterKeyValidityCheck) {
keyToReturn = @"Enter";
} else if (leftArrowValidityCheck) {
Expand Down