Skip to content

Conversation

@HeyImChris
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Pull in some AppDelegate changes we need for 0.63 to run properly

Changelog

[macOS] [Bug] - AppDelegate latest updates

Test Plan

I checked that some props are now getting set properly. This change makes macOS analogous to iOS which works in 0.63. I launched the test app and clicked through some screens like Button, ActivityIndicator, and DarkMode to make sure everything is loaded properly.

@HeyImChris HeyImChris requested a review from harrieshin April 19, 2021 18:31
@HeyImChris HeyImChris self-assigned this Apr 19, 2021
@HeyImChris HeyImChris requested a review from alloy as a code owner April 19, 2021 18:31
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 29d1271

@HeyImChris HeyImChris merged commit d8d702e into microsoft:0.63-stable Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants