Skip to content

Conversation

@HeyImChris
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Android doesn't need this so ifdef around their platform. Apple's TargetConditionals.h defines TARGET_OS_MAC to be true for iOS and OSX.

Test Plan

If CI builds it should be all set.

HeyImChris and others added 14 commits February 4, 2021 11:38
* Update RCTCxxBridge.mm

* add nullability checks
@HeyImChris HeyImChris requested a review from harrieshin April 26, 2021 15:22
@HeyImChris HeyImChris self-assigned this Apr 26, 2021
@HeyImChris HeyImChris requested a review from alloy as a code owner April 26, 2021 15:22
@pull-bot
Copy link

pull-bot commented Apr 26, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against e473466

@HeyImChris HeyImChris merged commit 0831292 into microsoft:0.63-stable Apr 26, 2021
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants