Use Boost GUID generator #11470

JunielKatarn · 2023-04-08T07:57:51Z

Description

Replacing WinRT with Boost for GUID generation.

Type of Change

Bug fix (non-breaking change which fixes an issue)

Why

winrt::Windows::Foundation::GuidHelper::CreateNewGuid() is not available on Windows versions 10.0.17134 and earlier, breaking the Blob module storage on those releases.

What

Drop usage of C++/WinRT GUID generation APIs with Boost APIs.

Testing

Desktop Integration Tests (Blob)

Microsoft Reviewers: Open in CodeFlow

…e-windows into OC/7771855/mkguid

vnext/Shared/Modules/BlobModule.h

… OC/7771855/mkguid

asklar · 2023-04-09T07:03:03Z

we don't support 10.0.17134 and earlier for RNW, and bringing in boost headers usually makes the build longer. can this be gated for office only?

JunielKatarn · 2023-04-10T09:11:11Z

we don't support 10.0.17134 and earlier for RNW, and bringing in boost headers usually makes the build longer. can this be gated for office only?

I'll measure the build times over several iterations.
If impact is null or negligible, I'd rather not maintain separate implementations.

Moreover, the WinRT APIs require string type conversion (wchar to char) so the Boost API may even be more efficient at runtime for our use case.

JunielKatarn · 2023-04-11T01:52:19Z

I tried 10 builds with and without my changes based on the latest main as of today, with the following settings:

Same workstation
Building Microsoft.ReactNative.dll
Pre-filled NuGet cache and Yarn setup commands
Removed vnext\build and vnext\target directories before each iteration
Build favor x64|Release

The build time difference is virtually non-existing.
This particular use of Boost is not impacting build performance empirically.
Merging as is to avoid diverging implementations without a noticeable build performance benefit.

* Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import

* Use Boost GUID generator (#11470) * Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import * Change files

* Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import

* Use Boost GUID generator (#11470) * Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import * Bump C++ Windows Version macros to Windows 10 (#11516) * Bump default _WIN32_WINNT_VERSION * Change files * Remove unused Beast-dependent code (#11517) * Remove unused Beast production code * Change files * clang format --------- Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> * Define FileReader turbo module (#11789) * Declare FileReaderTurboModule * Declare m_blobPersistor * Use msrn namespace alias in FileReader module * json lock * Update lock files * config * Implement ReadAsDataUrl * Define ReadAsText * Define FileReaderResource * Move persistor from module into resource * Rename module name name * Add using ModuleSpec * clang format * Change files * Define WebSocket TurboModule (#11802) * Add WSTurboModule.h * Implement CreateResource and MSRN SendEvent * Define IWebSocketModuleContentHandler::ProcessMessage with JSValueObject * Complete WebSocketTurboModule::CreateResource * Complete WebSocketTurboModule::Connect * Implement close, send, sendBinary and ping * Include NativeWebSocketModuleSpec * Make Close spec-compliant * Add spec-compliant method stubs * Make remaining existing methods spec-compliant * Move NOOP Add/RemoveListeners implementation into source file * clang format * Use double as keys for m_resourceMap * Change files * Define HTTP TurboModule (#11825) * Declare TurboModule * Generate NativeNetworkingWindows spec * Define HttpTurboModule * Begin resource setup * Initialize: Up to SetOnData * Define wchar_t event names * Migrate IRequestBodyHandler to JSValue IMPORTANT: Migrate and fix RequestArgs::Data * Migrate IResponseHandler to JSValue * Rename m_onDataDynamic as m_onDataObject * Implement Microsoft::React::Modules::ToJSValue * Migrate IHttpResource to JSValue * Fix Playground flavors ordering * Finish implementing Initialize * Define ToDynamic * Change files * Revert module.g.cpp * Revert "Revert module.g.cpp" This reverts commit 2f6c88a. * Define target SetCppWinRTReferences * clang format * Revert temporary symbol exports * Fix RedirectHttpFilterUnitTest import order * Preserve include ordering in RedirectHttpFilterUnitTest.cpp * Fix JSValueArray list constructor * Drop RCTNetworkingNative in favor of NativeNetworkingWindows * Add NativeNetworkingWindows to overrides * Fix overrides.json newline * Desktop int. tests: set RN_PLATFORM to win32 * Use iterator to lookup content types * Revert module.g.cpp to main * Use iterator for ToRequestBody content type * Drop namespace from JSValueObject usage * Finish HttpTurboModule * clang format * Use iOS HTTP spec * Use DynamicReader and DynamicWriter for folly conversions * Revert overrides.json * Don't add newline to overrides.json * Make RCTNetworking.windows.js a copy of RCTNetworking.ios.js * Override upgrade * Default IncludeFabricInterface to true (#11835) * Default IncludeFabricInterface to true * Change files * Remove IncludeFabricInterface from ExperimentalFeatures * Define Blob TurboModule (#11842) * REVERT: remove CompositionView exports * Declare BlobTurboModule * Revert "REVERT: remove CompositionView exports" This reverts commit 1ba874e. * Define BlobTurboModule * Declare IBlobResource * Define DefaultBlobResource * Define BlobCallbacks * Migrate BlobWebSocketModuleContentHandler * Pass needed args to DefaultBlobResource * Define IBlobResource +/- network handlers * Implement BlobModule using IBlobResource * Fix GetConstants ownership * Change files * Set up error callback! * clang format * Remove BlobModule::SharedState * Clean up includes and usings * Remove ProcessMessage folly variant * Remove folly:dynamic references * Define IBlobResource::FieldNames * Move IBlobPersistor out of Modules/ * Remove TODO comments * clang format * Add missing include to DefaultBlobResource * Change multi_threaded_map to single_threaded_map in WinRTHttpResource (#11604) * Change multi_threaded_map to single_threaded_map in WinRTHttpResource * Change files * Fix fetch failing with certain custom user agents (#11775) * Fix fetch failing with certain custom user agents * Change files * Use TurboModules for networking in MSRN (#11867) * Update packages.json * Define GetHttpTurboModuleName * Update packages.json * Define GetHttpModuleProvider * Define other netwk modules provider methods * Register networking turbomodules * Change files * clang format * Uncomment MSRN forward declarations * Remove cntPtr.h include * Remove CoreNativeModules * Revert packages.lock.json * Remove change files * Change files * Revert lock files * Use correct data types in FileReaderTurboModule::ReadAs* (#11902) * Use ReadAs* data argument as JSValueObject * Change files * Remove change files --------- Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: Liron Yahdav <lyahdav@users.noreply.github.com>

JunielKatarn added 4 commits April 7, 2023 15:50

Update package lock

05e474d

Use Boost UUID library

df031bf

Change files

ccf5bb9

Merge branch 'OC/7771855/mkguid' of github.com:jurocha-ms/react-nativ…

c84c21a

…e-windows into OC/7771855/mkguid

JunielKatarn requested review from a team as code owners April 8, 2023 07:57

JunielKatarn added the Area: Networking label Apr 8, 2023

vmoroz reviewed Apr 8, 2023

View reviewed changes

vnext/Shared/Modules/BlobModule.h Show resolved Hide resolved

vmoroz approved these changes Apr 8, 2023

View reviewed changes

JunielKatarn added 2 commits April 8, 2023 15:36

Merge branch 'main' of github.com:microsoft/react-native-windows into…

066edf1

… OC/7771855/mkguid

Remove GuidHelper import

0a24dcf

JunielKatarn added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Apr 8, 2023

JunielKatarn requested a review from a team April 9, 2023 00:41

dannyvv approved these changes Apr 10, 2023

View reviewed changes

JunielKatarn removed the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Apr 10, 2023

JunielKatarn merged commit 0a53092 into microsoft:main Apr 11, 2023

JunielKatarn deleted the OC/7771855/mkguid branch April 11, 2023 01:54

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Apr 11, 2023

Use Boost GUID generator (microsoft#11470)

7c01909

* Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Apr 11, 2023

Use Boost GUID generator (microsoft#11470)

cc3e5db

* Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Apr 11, 2023

Use Boost GUID generator (microsoft#11470)

2c7d452

* Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Apr 11, 2023

Use Boost GUID generator (microsoft#11470)

0919d38

* Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import

This was referenced Apr 11, 2023

[0.71] Use Boost GUID generator (#11470) #11478

Merged

[0.70] Use Boost GUID generator (#11470) #11479

Merged

[0.69] Use Boost GUID generator (#11470) #11480

Merged

[0.68] Use Boost GUID generator #11481

Merged

JunielKatarn added a commit that referenced this pull request Apr 11, 2023

[0.71] Use Boost GUID generator (#11470) (#11478)

860f65c

* Use Boost GUID generator (#11470) * Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import * Change files

JunielKatarn added a commit that referenced this pull request Apr 11, 2023

[0.70] Use Boost GUID generator (#11470) (#11479)

68b8432

* Use Boost GUID generator (#11470) * Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import * Change files

JunielKatarn added a commit that referenced this pull request Apr 11, 2023

[0.69] Use Boost GUID generator (#11470) (#11480)

6139c34

* Use Boost GUID generator (#11470) * Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import * Change files

JunielKatarn added a commit that referenced this pull request Apr 11, 2023

[0.68] Use Boost GUID generator (#11481)

dbc3b8b

* Use Boost GUID generator (#11470) * Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import * Change files

JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Jul 14, 2023

Use Boost GUID generator (microsoft#11470)

3482bb8

* Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import

JunielKatarn mentioned this pull request Jul 14, 2023

[0.72] Use TurboModules for networking in MSRN #11889

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Boost GUID generator #11470

Use Boost GUID generator #11470

Uh oh!

JunielKatarn commented Apr 8, 2023 •

edited by microsoft-github-policy-service bot

Loading

Uh oh!

Uh oh!

asklar commented Apr 9, 2023

Uh oh!

JunielKatarn commented Apr 10, 2023

Uh oh!

JunielKatarn commented Apr 11, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Use Boost GUID generator #11470

Use Boost GUID generator #11470

Uh oh!

Conversation

JunielKatarn commented Apr 8, 2023 • edited by microsoft-github-policy-service bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Why

What

Testing

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Uh oh!

asklar commented Apr 9, 2023

Uh oh!

JunielKatarn commented Apr 10, 2023

Uh oh!

JunielKatarn commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JunielKatarn commented Apr 8, 2023 •

edited by microsoft-github-policy-service bot

Loading

JunielKatarn commented Apr 11, 2023 •

edited

Loading