[0.72] Use TurboModules for networking in MSRN #11889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update package lock * Use Boost UUID library * Change files * Remove GuidHelper import
* Bump default _WIN32_WINNT_VERSION * Change files
* Remove unused Beast production code * Change files * clang format --------- Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
* Declare FileReaderTurboModule * Declare m_blobPersistor * Use msrn namespace alias in FileReader module * json lock * Update lock files * config * Implement ReadAsDataUrl * Define ReadAsText * Define FileReaderResource * Move persistor from module into resource * Rename module name name * Add using ModuleSpec * clang format * Change files
* Add WSTurboModule.h * Implement CreateResource and MSRN SendEvent * Define IWebSocketModuleContentHandler::ProcessMessage with JSValueObject * Complete WebSocketTurboModule::CreateResource * Complete WebSocketTurboModule::Connect * Implement close, send, sendBinary and ping * Include NativeWebSocketModuleSpec * Make Close spec-compliant * Add spec-compliant method stubs * Make remaining existing methods spec-compliant * Move NOOP Add/RemoveListeners implementation into source file * clang format * Use double as keys for m_resourceMap * Change files
* Declare TurboModule * Generate NativeNetworkingWindows spec * Define HttpTurboModule * Begin resource setup * Initialize: Up to SetOnData * Define wchar_t event names * Migrate IRequestBodyHandler to JSValue IMPORTANT: Migrate and fix RequestArgs::Data * Migrate IResponseHandler to JSValue * Rename m_onDataDynamic as m_onDataObject * Implement Microsoft::React::Modules::ToJSValue * Migrate IHttpResource to JSValue * Fix Playground flavors ordering * Finish implementing Initialize * Define ToDynamic * Change files * Revert module.g.cpp * Revert "Revert module.g.cpp" This reverts commit 2f6c88a. * Define target SetCppWinRTReferences * clang format * Revert temporary symbol exports * Fix RedirectHttpFilterUnitTest import order * Preserve include ordering in RedirectHttpFilterUnitTest.cpp * Fix JSValueArray list constructor * Drop RCTNetworkingNative in favor of NativeNetworkingWindows * Add NativeNetworkingWindows to overrides * Fix overrides.json newline * Desktop int. tests: set RN_PLATFORM to win32 * Use iterator to lookup content types * Revert module.g.cpp to main * Use iterator for ToRequestBody content type * Drop namespace from JSValueObject usage * Finish HttpTurboModule * clang format * Use iOS HTTP spec * Use DynamicReader and DynamicWriter for folly conversions * Revert overrides.json * Don't add newline to overrides.json * Make RCTNetworking.windows.js a copy of RCTNetworking.ios.js * Override upgrade
* Default IncludeFabricInterface to true * Change files * Remove IncludeFabricInterface from ExperimentalFeatures
* REVERT: remove CompositionView exports * Declare BlobTurboModule * Revert "REVERT: remove CompositionView exports" This reverts commit 1ba874e. * Define BlobTurboModule * Declare IBlobResource * Define DefaultBlobResource * Define BlobCallbacks * Migrate BlobWebSocketModuleContentHandler * Pass needed args to DefaultBlobResource * Define IBlobResource +/- network handlers * Implement BlobModule using IBlobResource * Fix GetConstants ownership * Change files * Set up error callback! * clang format * Remove BlobModule::SharedState * Clean up includes and usings * Remove ProcessMessage folly variant * Remove folly:dynamic references * Define IBlobResource::FieldNames * Move IBlobPersistor out of Modules/ * Remove TODO comments * clang format * Add missing include to DefaultBlobResource
…microsoft#11604) * Change multi_threaded_map to single_threaded_map in WinRTHttpResource * Change files
* Fix fetch failing with certain custom user agents * Change files
* Update packages.json * Define GetHttpTurboModuleName * Update packages.json * Define GetHttpModuleProvider * Define other netwk modules provider methods * Register networking turbomodules * Change files * clang format * Uncomment MSRN forward declarations * Remove cntPtr.h include * Remove CoreNativeModules * Revert packages.lock.json
vmoroz
approved these changes
Jul 18, 2023
…1902) * Use ReadAs* data argument as JSValueObject * Change files
vmoroz
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #11867, et al.
Microsoft Reviewers: codeflow:open?pullrequest=#11889