Skip to content

Add Coding Fixes to Composition Playground #11739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonthysell merged 2 commits into from
Jun 12, 2023
Merged

Add Coding Fixes to Composition Playground #11739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e138968
Add Coding Fixes to Composition Playground
chiaramooney Jun 9, 2023
3b6be0b
Address Feedback
chiaramooney Jun 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/playground/windows/playground-composition/Playground-Composition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ struct CompReactPackageProvider
: winrt::implements<CompReactPackageProvider, winrt::Microsoft::ReactNative::IReactPackageProvider> {
public: // IReactPackageProvider
void CreatePackage(winrt::Microsoft::ReactNative::IReactPackageBuilder const &packageBuilder) noexcept {
packageBuilder.AddTurboModule(L"DeviceInfo", winrt::Microsoft::ReactNative::MakeModuleProvider<DeviceInfo>());
AddAttributedModules(packageBuilder, true);
Copy link
Contributor

@acoates-ms acoates-ms Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need both of these lines at this point. Shouldn't AddAttributedModules add DeviceInfo?


CustomComponent::RegisterViewComponent(packageBuilder);
}
Expand Down Expand Up @@ -521,7 +521,6 @@ int RunPlayground(int showCmd, bool useWebDebugger) {
windowData.get());

WINRT_VERIFY(hwnd);
winrt::check_win32(!hwnd);

windowData.release();

Expand All @@ -539,7 +538,7 @@ int RunPlayground(int showCmd, bool useWebDebugger) {
}
}

return (int)msg.wParam;
return static_cast<int>(msg.wParam);
}

_Use_decl_annotations_ int CALLBACK WinMain(HINSTANCE instance, HINSTANCE, PSTR /* commandLine */, int showCmd) {
Expand Down
1 change: 0 additions & 1 deletion packages/playground/windows/playground-composition/Playground-Composition.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@
<ItemDefinitionGroup Condition="'$(Configuration)'=='Debug'">
<ClCompile>
<PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<LanguageStandard Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">stdcpp17</LanguageStandard>
</ClCompile>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)'=='Release'">
Expand Down