Add Coding Fixes to Composition Playground #11739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Area: Fabric
jonthysell
approved these changes
Jun 9, 2023
marlenecota
approved these changes
Jun 9, 2023
vmoroz
approved these changes
Jun 9, 2023
acoates-ms
reviewed
Jun 9, 2023
| public: // IReactPackageProvider | ||
| void CreatePackage(winrt::Microsoft::ReactNative::IReactPackageBuilder const &packageBuilder) noexcept { | ||
| packageBuilder.AddTurboModule(L"DeviceInfo", winrt::Microsoft::ReactNative::MakeModuleProvider<DeviceInfo>()); | ||
| AddAttributedModules(packageBuilder, true); |
Contributor
There was a problem hiding this comment.
Do you need both of these lines at this point. Shouldn't AddAttributedModules add DeviceInfo?
jonthysell
approved these changes
Jun 12, 2023
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Adding some of the coding feedback that arose during #11407 into the Playground Composition source for consistency.
Resolves #11413
Microsoft Reviewers: Open in CodeFlow