Skip to content

[0.72] Revert back to node 16 for all images#12709

Merged
jonthysell merged 7 commits intomicrosoft:0.72-stablefrom
jonthysell:revertnode16
Feb 10, 2024
Merged

[0.72] Revert back to node 16 for all images#12709
jonthysell merged 7 commits intomicrosoft:0.72-stablefrom
jonthysell:revertnode16

Conversation

@jonthysell
Copy link
Copy Markdown
Contributor

@jonthysell jonthysell commented Feb 9, 2024

Description

The previous change #12693 tried to switch RNW 0.72 to Node 18, which broke 0.72 publish, and but was only partially fixed with #12698.

This PR completes the revert.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

RN and RNW 0.72 require node 16, building against node 18 has issues, and even if we could fix those, that would be a breaking change to a stable branch.

What

N/A

Screenshots

N/A

Testing

N/A

Changelog

Should this change be included in the release notes: no

Microsoft Reviewers: Open in CodeFlow

@jonthysell jonthysell requested review from a team as code owners February 9, 2024 18:49
@jonthysell jonthysell enabled auto-merge (squash) February 9, 2024 18:49
@jonthysell
Copy link
Copy Markdown
Contributor Author

CLI tests won't work until #12712 is merged and published.

@jonthysell jonthysell requested a review from a team as a code owner February 9, 2024 21:36
@jonthysell jonthysell merged commit 4db77b3 into microsoft:0.72-stable Feb 10, 2024
jonthysell pushed a commit that referenced this pull request Feb 21, 2024
Disables node engine checks, workaround for issue #12711. Partial backport of #12709.
jonthysell pushed a commit that referenced this pull request Feb 21, 2024
Disables node engine checks, workaround for issue #12711. Partial backport of #12709.
@jonthysell jonthysell deleted the revertnode16 branch May 19, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants