Skip to content

[0.72] Revert back to node 16 for all images #12709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonthysell merged 7 commits into from
Feb 10, 2024
Merged

[0.72] Revert back to node 16 for all images #12709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d92b88
[0.72] Revert back to node 16 for all images
jthysell Feb 9, 2024
b9a3f82
update telemetry
jthysell Feb 9, 2024
e211457
Change files
jthysell Feb 9, 2024
222eb66
try resolution
jthysell Feb 9, 2024
806f258
try resolution 2
jthysell Feb 9, 2024
8517038
try resolution 3
jthysell Feb 9, 2024
96f22a8
disable engine checks
jthysell Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ado/compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ parameters:
default:
Medium:
name: rnw-pool-4-microsoft
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
Large:
name: rnw-pool-8-microsoft
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
- name: forceCodeQL
displayName: Force CodeQL to rebuild databases
type: boolean
Expand Down
6 changes: 3 additions & 3 deletions .ado/continuous.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ parameters:
default:
Small:
name: rnw-pool-2
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
Medium:
name: rnw-pool-4
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
MediumNode16:
name: rnw-pool-4
demands: ImageOverride -equals rnw-img-vs2022
Large:
name: rnw-pool-8
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022

stages:
- template: stages.yml
Expand Down
3 changes: 3 additions & 0 deletions .ado/templates/react-native-init.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ steps:
- script: yarn config set registry http://localhost:4873
displayName: Modify yarn config to point to local verdaccio server

- script: yarn config set ignore-engines true
displayName: Disable node engine checks # workaround for issue #12711

- ${{ if eq(parameters.useNuget, true) }}:
- script: |
npx --yes react-native-windows-init@latest --verbose --version $(npmVersion) --overwrite --language ${{ parameters.language }} --projectType ${{ parameters.projectType }} ${{ parameters.additionalInitArguments }} --experimentalNuGetDependency true --nuGetTestFeed $(System.DefaultWorkingDirectory)\NuGetTestFeed
Expand Down
6 changes: 3 additions & 3 deletions .ado/windows-vs-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ parameters:
default:
Small:
name: rnw-pool-2
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
Medium:
name: rnw-pool-4
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022
MediumNode16:
name: rnw-pool-4
demands: ImageOverride -equals rnw-img-vs2022
Large:
name: rnw-pool-8
demands: ImageOverride -equals rnw-img-vs2022-node18
demands: ImageOverride -equals rnw-img-vs2022

stages:
- template: stages.yml
Expand Down