perf(PropertySetter): Use generic delegate approach for view managers #1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent work to avoid reflection for native modules can also be applied to native props for view managers (which also uses reflection). Avoiding reflection invoke saves quite a few cycles. This change extracts the logic from ReflectionReactDelegateFactory to create the IGenericDelegate, and adds support for generic delegates where the instance isn't known up-front. We need this because the ViewManager responsible for creating all the PropertySetters only holds a reference to the ShadowNode type, not the ShadowNode instance itself.
Contributor
Author
|
cc @matthargett |
Reflection invoke automatically converts null arguments to default struct values. We have to do something similar here when we avoid reflection invoke.
reseul
approved these changes
Mar 6, 2018
ladipro
pushed a commit
to ladipro/react-native-windows
that referenced
this pull request
May 16, 2018
…microsoft#1691) The recent work to avoid reflection for native modules can also be applied to native props for view managers (which also uses reflection). Avoiding reflection invoke saves quite a few cycles. This change extracts the logic from ReflectionReactDelegateFactory to create the IGenericDelegate, and adds support for generic delegates where the instance isn't known up-front. We need this because the ViewManager responsible for creating all the PropertySetters only holds a reference to the ShadowNode type, not the ShadowNode instance itself. Also includes fix for reflection invoke behavior when dealing with null value types. Reflection invoke automatically converts null arguments to default value type (i.e., struct) values. We have to do something similar here when we invoke through generic delegates. (cherry picked from commit 614057f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent work to avoid reflection for native modules can also be applied to native props for view managers (which also uses reflection). Avoiding reflection invoke saves quite a few cycles.
This change extracts the logic from ReflectionReactDelegateFactory to create the IGenericDelegate, and adds support for generic delegates where the instance isn't known up-front. We need this because the ViewManager responsible for creating all the PropertySetters only holds a reference to the ShadowNode type, not the ShadowNode instance itself.