[AppTheme] Add high contrast properties and events #2697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
Contributor
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
ghost
added
Needs: Author Feedback
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
Contributor
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
reviewed
Jun 28, 2019
marlenecota
changed the title
ahimberg
reviewed
Jun 28, 2019
ahimberg
reviewed
Jun 28, 2019
ahimberg
approved these changes
Jun 28, 2019
marlenecota
approved these changes
Jun 28, 2019
kmelmon
reviewed
Jun 28, 2019
|
|
||
| bool AppTheme::getIsHighContrast() | ||
| { | ||
| return m_accessibilitySettings.HighContrast();; |
Contributor
There was a problem hiding this comment.
; [](start = 48, length = 1)
nit: extra semicolon
Contributor
Author
There was a problem hiding this comment.
Shoot, merged before the page fully loaded. Will fix this on next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in High Contrast awareness for React Native.
Adds High contrast event to the AppTheme module. Provides awareness of the 'isHighContrast' Boolean and 'highContrastColors' which are the RGB hex values for the eight main system colors from Windows:
ButtonFace
ButtonText
GrayText
Highlight
HighlightText
Hotlight
Window
WindowText
These are sent via the highContrastChanged event as strings of the form "#FFFFFF", matching conventional RGB color values for React Native.
Examples are also added to AccessibilityExample.tsx.
This PR also includes the addition of ThemingExample.tsx which adds an example of usage for the light and dark theme awareness from the AppTheme module.
Microsoft Reviewers: Open in CodeFlow