-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[AppTheme] Add high contrast properties and events #2697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
decrowle
merged 9 commits into
microsoft:master
from
decrowle:user/decrowle/HighContrastEvents
Jun 29, 2019
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8c4aa49
Enable High Contrast Events
decrowle 898e4e5
Add Theming test
decrowle 79e578a
Convert RGB to hex and rename RGB to Colors
decrowle cbd5625
PR draft response
decrowle 029b6e8
Use interesting color in second View in AccessibilityExample
decrowle 70487b7
Responding to PR feedback
decrowle 189e41b
Making AccessibilityExample better showcase highcontrast colors
decrowle 2c2c499
PR reponse and improve AccessibilityExample
decrowle 7d1dd73
Removing iomanip include
decrowle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| export interface IHighContrastColors { | ||
| ButtonFaceColor: string; | ||
| ButtonTextColor: string; | ||
| GrayTextColor: string; | ||
| HighlightColor: string; | ||
| HighlightTextColor: string; | ||
| HotlightColor: string; | ||
| WindowColor: string; | ||
| WindowTextColor: string; | ||
| } | ||
|
|
||
| export interface IAppThemeChangedEvent { | ||
| currentTheme: string; | ||
| } | ||
|
|
||
| export interface IHighContrastChangedEvent { | ||
| isHighContrast: boolean; | ||
| highContrastColors: IHighContrastColors; | ||
| } |
13 changes: 0 additions & 13 deletions
13
vnext/src/Libraries/Modules/AppTheme/__mocks__/AppTheme.uwp.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra semicolon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, merged before the page fully loaded. Will fix this on next PR.