CalculatedAnimation #3482
Merged
CalculatedAnimation #3482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2019 18:45
ghost
added
the
This was referenced Oct 22, 2019
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Dec 8, 2021
It looks like we used to previously pull the start value on the fly and then later changed CalculatedAnimatedDriver to store the starting value in `m_startValue` and migrated to using that in DecayAnimationDriver in microsoft#3482.
NickGerleman
added a commit
that referenced
this pull request
Dec 9, 2021
* Cleans up unused code from DecayAnimationDriver It looks like we used to previously pull the start value on the fly and then later changed CalculatedAnimatedDriver to store the starting value in `m_startValue` and migrated to using that in DecayAnimationDriver in #3482. * Change files Co-authored-by: Nick Gerleman <ngerlem@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements Decay animations and creates a base class CalculatedAnimation that factors the logic that used to be in SpringAnimation so that it can be used by DecayAnimation. The formula for decay animation was wrong; in reality a decay animation has an exponential decay. This animation cannot be expressed as a cubic bezier curve so instead we use keyframes like Spring animation does (which has a neg-exponential component too). This addresses #3481 (and #3477 )
Microsoft Reviewers: Open in CodeFlow