Cleans up unused code from DecayAnimationDriver #9258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like we used to previously pull the start value on the fly and then later changed CalculatedAnimatedDriver to store the starting value in `m_startValue` and migrated to using that in DecayAnimationDriver in microsoft#3482.
NickGerleman
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
It looks like we used to previously pull the start value on the fly and then later changed CalculatedAnimatedDriver to store the starting value in
m_startValueand migrated to using that in DecayAnimationDriver in #3482.What
Removes dead code for computing the startValue.
Testing
Decay animations still work:
React.Native.Playground.Win32.2021-12-08.16-03-42.mp4
Microsoft Reviewers: Open in CodeFlow