Skip to content

Fix remaining JSI unit tests and some code clean up. #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hansenyy merged 13 commits into from
Oct 25, 2019
Merged

Fix remaining JSI unit tests and some code clean up. #3514

hansenyy merged 13 commits into from
Oct 25, 2019

Conversation

@hansenyy
Copy link
Contributor

@hansenyy hansenyy commented Oct 24, 2019 •
edited
Loading

This PR:

  • Fix all JSI Unit tests with two small caveats:
    • getHostFunction() is still not supported.
    • The length property of a host function always returns zero.
  • Reorder some functions in ChakraRuntime.h for better readability.
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the vnext label Oct 24, 2019
@hansenyy hansenyy requested review from a team, NikoAri, mganandraj and tudorms October 24, 2019 21:39
@hansenyy hansenyy marked this pull request as ready for review October 24, 2019 21:39
@hansenyy hansenyy requested a review from a team as a code owner October 24, 2019 21:39
tudorms
tudorms reviewed Oct 24, 2019
View reviewed changes
tudorms
tudorms approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@tudorms tudorms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hansenyy hansenyy merged commit 0752e64 into microsoft:master Oct 25, 2019
@hansenyy hansenyy deleted the ImproveHostObjAndFunc branch October 25, 2019 17:17
This was referenced Oct 30, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tudorms tudorms tudorms approved these changes

@mganandraj mganandraj Awaiting requested review from mganandraj

@NikoAri NikoAri Awaiting requested review from NikoAri

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hansenyy @tudorms