Skip to content

Add Winui 2.2 framework package #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
Nov 23, 2019
Merged

Add Winui 2.2 framework package #3622

3 commits merged into from
Nov 23, 2019

Conversation

@licanhua
Copy link
Contributor

@licanhua licanhua commented Nov 7, 2019 •
edited
Loading

Complete part of #3521. CLI templates change will be in another PR.

This is the integration with WinUI 2.2.190917002 framework package.
It’s a breaking change, and you may be impacted:
You are using an old version of WinUI like 2.1.
You are using WinUI prelease
Your product is not shipped from Store. You may have to install WinUI by yourself.

  1. _WinUIWorkaround is added to workaround problem WinUI issue 1512.
  2. All our name space is 'react.uwp', so I changed 'RootNamespace' to make mdmerge.exe happy. and CppWinRTNamespaceMergeDepth is added to avoid compilation error because of RootNamespace change.
Microsoft Reviewers: Open in CodeFlow

@licanhua licanhua requested a review from a team as a code owner November 7, 2019 21:14
@ghost ghost added the vnext label Nov 7, 2019
@licanhua licanhua changed the title Add Winui prerelease nuget Add Winui 2.2 framework package Nov 8, 2019
chrisglein
chrisglein approved these changes Nov 8, 2019
View reviewed changes
@licanhua licanhua mentioned this pull request Nov 22, 2019
Closed
stecrain
stecrain reviewed Nov 22, 2019
View reviewed changes
@stecrain
Copy link
Contributor

stecrain commented Nov 22, 2019 •
edited
Loading

Are there any changes to the cli template needed as part of this?
Since you are advertising it as a breaking change I assume the cli template would need to be updated 🤔

@licanhua
Copy link
Contributor Author

licanhua commented Nov 23, 2019

Are there any changes to the cli template needed as part of this?
Since you are advertising it as a breaking change I assume the cli template would need to be updated 🤔

Good call. I reword the description. and it will be in the next PR

dotnetjunky
dotnetjunky reviewed Nov 23, 2019
View reviewed changes
@licanhua licanhua added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Nov 23, 2019
@ghost
Copy link

ghost commented Nov 23, 2019

Hello @licanhua!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

kmelmon
kmelmon approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@kmelmon kmelmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost merged commit 160f555 into microsoft:master Nov 23, 2019
@licanhua licanhua deleted the winui branch November 23, 2019 04:23
licanhua added a commit that referenced this pull request Nov 25, 2019
@licanhua
Revert "Add Winui 2.2 framework package (#3622)"
05b4247 
This reverts commit 160f555.
@licanhua licanhua mentioned this pull request Nov 25, 2019
Merged
ghost pushed a commit that referenced this pull request Nov 25, 2019
@licanhua
Revert "Add Winui 2.2 framework package" (#3703)
630b836 
* Revert "Add Winui 2.2 framework package (#3622)"

This reverts commit 160f555.

* Change files
@licanhua licanhua restored the winui branch November 25, 2019 22:40
@licanhua licanhua mentioned this pull request Nov 26, 2019
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotnetjunky dotnetjunky dotnetjunky left review comments

@chrisglein chrisglein chrisglein approved these changes

+2 more reviewers

@stecrain stecrain stecrain left review comments

@kmelmon kmelmon kmelmon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@licanhua @stecrain @dotnetjunky @chrisglein @kmelmon