Skip to content

Conversation

@licanhua
Copy link
Contributor

@licanhua licanhua commented Nov 26, 2019

Fix #3521
Fix #3695

It’s a breaking change, and you may be impacted:

  • You are using an old version of WinUI like 2.1.
  • You are using WinUI prelease
  • Your product will not be shipped from Store. You may have to install WinUI dependency by yourself.

You have to manually add the Microsoft.UI.Xaml nuget to your project if you your app is created from old template

This is the integration with WinUI 2.3.191129002 framework package.

All our name space is 'react.uwp', so I changed 'RootNamespace' to make mdmerge.exe happy. and CppWinRTNamespaceMergeDepth is added to avoid compilation error because of RootNamespace change.

Microsoft Reviewers: Open in CodeFlow

@licanhua licanhua requested a review from a team as a code owner November 26, 2019 01:38
@licanhua
Copy link
Contributor Author

licanhua commented Nov 26, 2019

This is a redo of PR #3622 and make all project add reference of WinUI #Closed

@licanhua licanhua changed the title Add dependency WinUI 2.2 framework package Add dependency WinUI 2.3 framework package Dec 3, 2019
Copy link
Contributor

@ddalp ddalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove workaround for WinUI integration Add dependency on microsoft-ui-xaml (WinUI 2.x)

2 participants