Skip to content

Conversation

@NickGerleman
Copy link
Contributor

@NickGerleman NickGerleman commented Jan 16, 2020

CI machines pass an environment variable as a custom build property to
MSBuild in order to change intermediate build directory. Rely on this
environment variable if set.

Microsoft Reviewers: Open in CodeFlow

CI machines pass an environment variable as a custom build property to
MSBuild in order to change intermediate build directory. Rely on this
environment variable if set.
@NickGerleman NickGerleman requested a review from a team as a code owner January 16, 2020 04:37
@ghost ghost added the vnext label Jan 16, 2020
@NickGerleman
Copy link
Contributor Author

Er, I guess technically not an environment variable but I believe they should be added to the environment when running commands.

@ghost ghost added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Jan 16, 2020
@NickGerleman
Copy link
Contributor Author

Hmm, it looks like we will always skip the LayoutHeaders build step apart from x64 debug in publish, unless an ADO variable is set to enable it. I.e. from what I can tell, without CI changes I don't have a way to evaluate the script output until we're actually publishing.

@JunielKatarn I'm going to set this to AutoMerge and take a look at the publish job output when it passes. This is already broken, so we can't really do more damage at least. I do like the idea about being able to pass a base directory to the PowerShell script as well, just because it makes it a bit less likely we will break if refactoring CI scripts. I will make that change if this one doesn't work.

@NickGerleman NickGerleman added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jan 16, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

Hello @NickGerleman!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 14 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@NickGerleman NickGerleman merged commit 525b5a0 into microsoft:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants