Fix Layout-Headers for Publish Try 2 #3888
Conversation
Add a missing directory separator that wasn't in the env variable. Add LayoutHeaders to a build flavor in the PR matrix so we can find this earlier.
NickGerleman
added
the
AutoMerge
|
Hello @NickGerleman! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
vnext/Scripts/Tfs/Layout-Headers.ps1
Outdated
| } | ||
|
|
||
| $ReactNativeRoot = $intermediateBuildDir + $relativeRnDir | ||
| $ReactNativeRoot = $intermediateBuildDir + "\" + $relativeRnDir |
There was a problem hiding this comment.
Use Join-Path instead.
i.e.
Join-Path -Path $intermediateBuildDir -ChildPath $relativeRnDir
ghost
added
the
Needs: Author Feedback
|
@JunielKatarn there's some weirdness going on with CI. It looks like in prior builds most of "Build and Pack Nuget" completely no-oped, even for desktop. In this one we deterministically fail when trying to pack ReactUWP x64 debug, even though we ran a script to remove ReactUWP from the NuSpec. Still trying to figure out how adding LayoutHeaders to the build matrix could change this. Us no-oping on previous PRs seems like a bug though. Know what's going on here? |
ghost
removed
the
Needs: Author Feedback
|
Going to create an issue for the Nuget Issues and just leave header layout out of the PR Matrix for now. |
|
@JunielKatarn could you take a look at this again? |
ghost
merged commit 2 participants
Continue from #3887
Add a missing directory separator that wasn't in the env variable.
Add(see update below)LayoutHeaders to a build flavor in the PR matrix so we can find this
earlier.
Microsoft Reviewers: Open in CodeFlow