Switching to VS 2019 and v142 tools

[jonthysell]

• All builds moved to VS 2019 VMs
• Only v142 toolset installed
• Solutions and projects updated to VS 16.0, to not require v141
• CLI scripts updated to not use v141

Addresses issues #3476, #3801, #3960

Microsoft Reviewers: Open in CodeFlow

[asklar]

link this issue #3476

[JunielKatarn]

Are we ready for this change yet?

Last time this was discussed, there were dependent projects that were forced to use v141.
In reality, v142 and v141 are not binary-compatible (when linking with optimizations).

[asklar]

we couldn't get any details on why 141 is needed since October. I say we're ready for this change and if it breaks something, we'll hear about it and can react then.

---

In reply to: 358572903 [](ancestors = 358572903)

[JunielKatarn]

we couldn't get any details on why 141 is needed since October. I say we're ready for this change and if it breaks something, we'll hear about it and can react then.

In reply to: 358572903 [](ancestors = 358572903)

We would hear about it almost immediately.
I have sent a message with details.
Can we discuss offline?

[asklar]

can do away with passing version and always assume 16

---

Refers to: vnext/local-cli/runWindows/utils/msbuildtools.js:165 in f3cd019. [](commit_id = f3cd019, deletion_comment = False)

[asklar]

    });

don't need this, just call checkMSBuildVersion(16, ...)

omit version if you'd like

---

Refers to: vnext/local-cli/runWindows/utils/msbuildtools.js:199 in f3cd019. [](commit_id = f3cd019, deletion_comment = False)

[jonthysell]

@jonthysell Jon Thysell (JAUNTY) FTE

Is the build process not working without calling VCVars?

Does this happen locally, or only during CI?

It was a red herring - I got the build working for c# apps with msbuild-x64 by preventing the buggy target from running. #4462

[asklar]

[JunielKatarn]

Unblocking, but need to review again before explicitly signing off.

Reviewing again...

[vmoroz]

[rkokXXVV]

Hey guys. Is the support for VS2019 with v142 tools now live? I've just tried to install RNW for RN0.61.5 and it is still failing to build with VS2019 and v142

Cheers

[asklar]

Hey guys. Is the support for VS2019 with v142 tools now live? I've just tried to install RNW for RN0.61.5 and it is still failing to build with VS2019 and v142

Cheers

@rkokXXVV it is live but likely not something we'll backport. check out what's in master today instead! :)

[NickGerleman]

Alex is right, that you can test bleeding edge features using our master branch. It's important to know that our master branch won't work with stable releases of React Native, and sees frequent breaking changes.

Visual Studio V142 support is included in React Native Windows 0.62, which we're in the process of taking out of prerelease. You should get it automatically if you run react-native-windows-init on a React Native 0.62 project.