-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Switching to VS 2019 and v142 tools #4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
8ce5ad3
Update ADO builds to use VS 2019 and v142 toolset
jonthysell ec8b9a5
Update projects for VS 2019 and v142
jonthysell f3cd019
Update solutuions for VS 2019 and v142, move unit tests out of sample…
jonthysell 3a17a78
Add comment to deforked file with upstream PR link
jonthysell 48a6c26
Replace forked file with project change
jonthysell 4112efc
Change files
jonthysell f7a7d35
Fixed failing E2Etests
jonthysell e9b5ab1
Re-added Microsoft.ReactNative mangaed unit tests
jonthysell 42368d1
Disable broken arm64 managed unit tests
jonthysell c0d94c8
Enable universal unit tests on x86
jonthysell 22ff29f
Addressing feedback: changing variable name
jonthysell 8f28776
Addressing feedback: removing langauge standard in proj files
jonthysell 037a5d6
Addressing feedback: removing ReactNativeWindows_PlatformToolset
jonthysell 653da3a
Addressing feedback: Moving PlatformToolset to React.Cpp.props
jonthysell ca20d2f
Addressing feedback: variables syntax in task condition
jonthysell e33c65f
Addressing feedback: reverting e2etest masters
jonthysell 318378c
Fix ControlStyleRoundBorder E2ETest
jonthysell dbe708a
Added better logging to DirectMAnipulation e2e tests
jonthysell b57e511
Merge branch 'master' into vs2019
jonthysell db83c65
Merge branch 'master' into vs2019
jonthysell 83c816a
Merge branch 'master' into vs2019
jonthysell 60325a2
Merge branch 'master' into vs2019
jonthysell 6ffeaee
Merge branch 'master' into vs2019
jonthysell 4d85d55
Switch back to x64 msbuild
jonthysell 819c06d
Merge branch 'master' into vs2019
jonthysell e50f95c
Try switch to vsbuild
jonthysell 32a6533
vsbuild update
jonthysell 88b903d
Added vcvarsamd64_x86.bat
jonthysell bc2fa3b
Added vcvarsamd64_x86.bat fix
jonthysell f148bd1
Call vcvarsamd64_x86.bat with call
jonthysell 09462c1
Remove vcvars
jonthysell b53e627
Added <AppxGeneratePrisForPortableLibrariesEnabled>false</AppxGenerat…
jonthysell cc77dc6
Merge branch 'master' into vs2019
jonthysell fc9768a
Build testcli with specified
jonthysell 1b0fb70
Merge branch 'master' into vs2019
jonthysell 6c95619
Update all project files to 16.0
jonthysell c06ccd8
Remove v141 from playground-win32
jonthysell 9860fbd
Remove langstandard from playground-win32
jonthysell b4c5f0a
Fix E2ETEsts
jonthysell 95c5e0e
Moved forced stdexcept include
jonthysell d7d988b
Merge branch 'master' into vs2019
jonthysell 31e0f90
Revert unnecessary E2ETest changes
jonthysell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| variables: | ||
| MSBuildArchitecture: x64 | ||
| MSBuildPreferredToolArchitecture: x64 | ||
| MSBuildPlatformToolset: v141 | ||
| MSBuildPlatformToolset: v142 | ||
jonthysell marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| TargetPlatformVersion: 10.0.18362.0 | ||
| Win10Version: 18362 | ||
| VsInstallerUri: 'https://download.visualstudio.microsoft.com/download/pr/c4fef23e-cc45-4836-9544-70e213134bc8/1ee5717e9a1e05015756dff77eb27d554a79a6db91f2716d836df368381af9a1/vs_Enterprise.exe' | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| variables: | ||
| VmImage: windows-2019 | ||
| VsComponents: Microsoft.Component.MSBuild,Microsoft.VisualStudio.ComponentGroup.UWP.VC,Microsoft.VisualStudio.Component.VC.Tools.x86.x64,Microsoft.VisualStudio.Component.VC.Tools.ARM,Microsoft.VisualStudio.Component.VC.Tools.ARM64,Microsoft.VisualStudio.Component.VC.v141.x86.x64,Microsoft.VisualStudio.ComponentGroup.UWP.VC.v141,Microsoft.VisualStudio.Component.VC.v141.ARM,Microsoft.VisualStudio.Component.VC.v141.ARM64 | ||
| VsComponents: 'Microsoft.Component.MSBuild,Microsoft.VisualStudio.ComponentGroup.UWP.VC,Microsoft.VisualStudio.Component.VC.Tools.x86.x64,Microsoft.VisualStudio.Component.VC.Tools.ARM,Microsoft.VisualStudio.Component.VC.Tools.ARM64' | ||
| MSBuildVersion: 16.0 | ||
| GoogleTestAdapterPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\Extensions\pemwd5jw.szc' | ||
| BaseIntDir: $(Agent.HomeDirectory)\BaseIntDir # redirect to C: | ||
| runCodesignValidationInjection: false | ||
| runCodesignValidationInjection: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Switching to VS 2019 and v142 tools", | ||
| "packageName": "react-native-windows", | ||
| "email": "jthysell@microsoft.com", | ||
| "commit": "48a6c268b66140a908ef37e66f586a527e93aac0", | ||
| "dependentChangeType": "patch", | ||
| "date": "2020-02-13T22:37:32.478Z" | ||
| } |
9 changes: 9 additions & 0 deletions
9
change/react-native-windows-extended-2020-02-13-14-37-32-vs2019.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Switching to VS 2019 and v142 tools", | ||
| "packageName": "react-native-windows-extended", | ||
| "email": "jthysell@microsoft.com", | ||
| "commit": "48a6c268b66140a908ef37e66f586a527e93aac0", | ||
| "dependentChangeType": "patch", | ||
| "date": "2020-02-13T22:37:26.611Z" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...icrosoft-reactnative-sampleapps/windows/SampleLibraryCPP/SampleLibraryCPP.vcxproj.filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.