Skip to content

Stop requiring signing certs for test apps #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4 commits merged into from
Mar 12, 2020
Merged

Stop requiring signing certs for test apps #4303

4 commits merged into from
Mar 12, 2020

Conversation

@acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented Mar 12, 2020 •
edited by ghost
Loading

Certs expired, rather than renewing them, I think this will stop us needing them.

Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested a review from a team as a code owner March 12, 2020 14:34
@ghost ghost added the vnext label Mar 12, 2020
@acoates-ms acoates-ms added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Mar 12, 2020
@ghost
Copy link

ghost commented Mar 12, 2020

Hello @acoates-ms!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit b2ee2ad into microsoft:master Mar 12, 2020
@acoates-ms acoates-ms deleted the fixcerts branch March 12, 2020 17:01
@kmelmon kmelmon mentioned this pull request Mar 17, 2020
Merged
@jagorrin jagorrin mentioned this pull request Mar 17, 2020
Merged
ghost pushed a commit that referenced this pull request Mar 17, 2020
@jagorrin @acoates-ms
Stop requiring signing certs for test apps (#4303) (#4338)
de46b89 
* Fix certs

* Change files

* fix

* E2E needs a cert to run?

Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NickGerleman NickGerleman NickGerleman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acoates-ms @NickGerleman