Skip to content

Stop requiring signing certs for test apps #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from
Mar 12, 2020
Merged

Stop requiring signing certs for test apps #4303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
966064e
Fix certs
acoates-ms Mar 12, 2020
7f8303f
Change files
acoates-ms Mar 12, 2020
e937ae4
fix
acoates-ms Mar 12, 2020
0cf4157
E2E needs a cert to run?
acoates-ms Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change/react-native-windows-2020-03-12-07-33-25-fixcerts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "none",
"comment": "Stop requiring signing certs for test apps",
"packageName": "react-native-windows",
"email": "acoates@microsoft.com",
"commit": "966064ea9e1049dbe84878185d6cbbfa85159e2e",
"dependentChangeType": "patch",
"date": "2020-03-12T14:33:24.996Z"
}
3 changes: 2 additions & 1 deletion packages/E2ETest/windows/ReactUWPTestApp/ReactUWPTestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
<FileAlignment>512</FileAlignment>
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<WindowsXamlEnableOverview>true</WindowsXamlEnableOverview>
<PackageCertificateThumbprint>867D41FE5091AED426000143497EA4DFC29A8097</PackageCertificateThumbprint>
<PackageCertificateThumbprint>FCDD40CD2A4E90DD1F10E5C04D5A958E6B5311CA</PackageCertificateThumbprint>
<PackageCertificateKeyFile>ReactUWPTestApp_TemporaryKey.pfx</PackageCertificateKeyFile>
<AppxPackageSigningEnabled>True</AppxPackageSigningEnabled>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
<DebugSymbols>true</DebugSymbols>
Expand Down
Binary file modified packages/E2ETest/windows/ReactUWPTestApp/ReactUWPTestApp_TemporaryKey.pfx
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions packages/playground/windows/playground-win32/Playground-win32.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup>
<AppxPackageSigningEnabled>False</AppxPackageSigningEnabled>
<PackageCertificateThumbprint>867D41FE5091AED426000143497EA4DFC29A8097</PackageCertificateThumbprint>
<PackageCertificateKeyFile>Playground_TemporaryKey.pfx</PackageCertificateKeyFile>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions packages/playground/windows/playground/Playground.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup>
<AppxPackageSigningEnabled>False</AppxPackageSigningEnabled>
<PackageCertificateThumbprint>867D41FE5091AED426000143497EA4DFC29A8097</PackageCertificateThumbprint>
<PackageCertificateKeyFile>Playground_TemporaryKey.pfx</PackageCertificateKeyFile>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions vnext/Universal.IntegrationTests/React.Windows.Universal.IntegrationTests.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
<PropertyGroup Label="UserMacros" />
<PropertyGroup>
<IncludePath>$(ReactNativeWindowsDir)stubs;$(FollyDir);$(ReactNativeDir)\ReactCommon;$(YogaDir);$(ReactNativeWindowsDir)Common;$(ReactNativeWindowsDir)include;$(ReactNativeWindowsDir)ReactWindowsCore;$(ReactNativeWindowsDir)include\ReactWindowsCore;$(ReactNativeWindowsDir)include\ReactUWP;$(ReactNativeWindowsDir)ReactUWP;$(IncludePath)</IncludePath>
<AppxPackageSigningEnabled>False</AppxPackageSigningEnabled>
<PackageCertificateKeyFile>React.Windows.Universal.IntegrationTests_TemporaryKey.pfx</PackageCertificateKeyFile>
<PackageCertificateThumbprint>3178F848DBCD8815543899DE47FD75569C39F355</PackageCertificateThumbprint>
</PropertyGroup>
Expand Down
5 changes: 2 additions & 3 deletions vnext/Universal.UnitTests/React.Windows.Universal.UnitTests.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,15 @@
<ImportGroup Label="PropertySheets">
<Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
</ImportGroup>
<PropertyGroup>
<PackageCertificateKeyFile>React.Windows.Universal.UnitTests_TemporaryKey.pfx</PackageCertificateKeyFile>
</PropertyGroup>
<PropertyGroup>
<LinkIncremental>true</LinkIncremental>
</PropertyGroup>
<PropertyGroup>
<OutDir>$(ReactNativeWindowsDir)target\$(Platform)\$(Configuration)\$(MSBuildProjectName)\</OutDir>
<IntDir>$(ReactNativeWindowsDir)build\$(Platform)\$(Configuration)\$(MSBuildProjectName)\</IntDir>
<AppxPackageSigningEnabled>False</AppxPackageSigningEnabled>
<PackageCertificateThumbprint>63B3B5D575C3DE72218E4A75BFE5661B129042E8</PackageCertificateThumbprint>
<PackageCertificateKeyFile>React.Windows.Universal.UnitTests_TemporaryKey.pfx</PackageCertificateKeyFile>
</PropertyGroup>
<ItemDefinitionGroup>
<ClCompile>
Expand Down