Add timeout to certificate generation on project init #4430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
@acoates-ms FYI this is set to fix the wrong issue number
|
NickGerleman
approved these changes
Mar 26, 2020
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Apr 3, 2020
* Add a timeout to catch hangs during cert generation * Change files
ghost
pushed a commit
that referenced
this pull request
Apr 3, 2020
* Fix crash when calling measure on non-framework element (#4473) * Fix crash when calling measure on non-framework element * Change files * Fix new project build (#4469) * Set $(ReactNativeWindowsDir) before it is used * Change files * Update MSBuild ADO Tasks to use MSBuild x64 (#4462) * Removed x86 override for msbuild tasks in CI, publish * Switch from MSBuild to VSBuild * Added `<AppxGeneratePrisForPortableLibrariesEnabled>false</AppxGeneratePrisForPortableLibrariesEnabled>` to C# app projects to fix build issues with msbuild x64 * Added `/p:AppxGeneratePrisForPortableLibrariesEnabled=false` for testcli build task * Some Direct Debugging fixes (#4440) * Fix direct debugging * formatting * Change files * Add timeout to certificate generation on project init (#4430) * Add a timeout to catch hangs during cert generation * Change files * Update change files to use patch version bumping * publishing fix Co-authored-by: Vladimir Morozov <vmoroz@users.noreply.github.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3930
Another attempt at ensuring that project init doesn't hang. #4423 helped on my local machine at least. But user feedback is that that didn't prevent all the hangs. -- So I'm adding a 15 second timeout to the certificate generation. If it timesout it will fallback to the placeholder cert, as it does on other failures, or when generating from a non-windows box.
Microsoft Reviewers: Open in CodeFlow